eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
863 stars 783 forks source link

Validation Error on mqtt binding configuration #6706

Open PascalTurbo opened 5 years ago

PascalTurbo commented 5 years ago

While configuring mqtt binding like described here: MQTT Generic Thing Binding, openhab logs a validation error:

Provide a thing type ID and a thing ID in this format:
 <thingTypeId> <thingId>

because of the line Thing mqtt:topic:mything.

JueBag commented 5 years ago

Does openHAB log validation errors, or is it the VSCode editor?

In any case one has to note the different channel syntax when linking an item in case of creating the things via PaperUI or via files. PaperUI: mqtt:topic:myThing File: mqtt:topic:myBroker:myThing This difference created some missunderstandings. The actually needed syntax can be copied from PaperUI in any case!

davidgraeff commented 5 years ago

See https://community.openhab.org/t/how-to-configure-mqtt-2-binding/60458/10?u=david_graeff

So the line is correct. But the Visual Studio Code extension doesn't know this syntax yet, because it was uncommon before the MQTT binding.

PascalTurbo commented 5 years ago

Does openHAB log validation errors, or is it the VSCode editor?

The line you've seen in my first message comes from OpenHAB log, but like @davidgraeff says vscode also logs the error.

davidgraeff commented 5 years ago

I wonder if I should change the example to the mqtt:topic:myBroker:myThing syntax instead.

JueBag commented 5 years ago

I already made a PR with that exact change (which has an "IP-Validation" problem )