search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 783 forks source link

[MQTT] Updated Readme #6707

Closed JueBag closed 5 years ago

JueBag commented 5 years ago

Corrected Item syntax and added a note about the difference syntax when creating the things via PaperUI or files.

Signed-off-by: Juergen Baginski opus42@gmx.de

JueBag commented 5 years ago

I have no idea how that "ip-validation" check could be passed. The user "noreply@github.com" is mentioned in the details?????

davidgraeff commented 5 years ago

The signed off by line is a little off: Signed-off-by: Juergen Baginski opus42@gmx.de (github: JueBag)

It should read Signed-off-by: Juergen Baginski <opus42@gmx.de>

JueBag commented 5 years ago

Changed it, but that doesn't seem to trigger the check again.

davidgraeff commented 5 years ago

You didn't change the actual commit, only the description here on github. You need to git --amend -s and git push -f (force change push). If you are using the webeditor, you actually need to close this PR and do the changes again with a correct signed off by line. The webeditor is a little limited in this regard.

JueBag commented 5 years ago

Once again "git magic", since I did this change on the browser I have to digg a bit deeper for that.

Made the change using Source Tree, not sure if that was all needed.

davidgraeff commented 5 years ago

I have done successfully validated commits on the webeditor, too. It's possible. But you need to add this Signed-off-by: Juergen Baginski <opus42@gmx.de> line at the end of the commit message. Would be so nice if Github had a checkbox to tick.

JueBag commented 5 years ago

All that just because I did remember to SignOff, my mistake was to use the signature that worked back in 2016 (while creating the Tankerkönig binding). I did have much trouble with git back then also! It looks to me now that I changed the actual commit using Source Tree, however looking from the browser it doesn't show. I'm (again) out off ideas, if it would be easy to drop/delete all those and make a new I would do it!

Sorry for all that, THANKS for all the help and a big THANK YOU for the new mqtt binding !

davidgraeff commented 5 years ago

I'm not using source tree. You need to look for a push (with force) option in that GUI.