search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 783 forks source link

Solve parts of #6749 #6766

Closed jochen314 closed 5 years ago

jochen314 commented 5 years ago

The first error on #6749 is caused by an error in HaID.

I created tests cases for HaID and fixed the problem.

davidgraeff commented 5 years ago

Thanks @jochen314

@maggu2810 Eclipse by default ignores the ESH formatter settings in a fresh installation at the moment. This makes it hard for new contributors.

A temporary documentation page / wiki page with how to reapply the formatter is probably helpful for the moment. I have no eclipse at hand right now @jochen314 but have a look in the settings window and search for java formatting. There should be an ESH profile, already selected. Select something else, apply, reselect the ESH profile, apply.

maggu2810 commented 5 years ago

@jochen314 It seems there is no valid ECA for git@jochen.susca.de (I also tried a manual check).

jochen314 commented 5 years ago

ECA should be there now. Sorry, it is my first participation in an eclipse project :-)

maggu2810 commented 5 years ago

Thanks for your effort @jochen314 The ECA needs to be done only once, so you can now fix all the other code of all eclipse projects :wink: