eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 787 forks source link

[hue] Prevent NPE if 'modelid' is 'null' #6813

Closed cweitkamp closed 5 years ago

cweitkamp commented 5 years ago

When pointing the Hue binding to a deCONZ emulated bridge it may occur that devices using an up-to-date firmware, which is not supported properly, and some properties (e.g. the modelid) have a null value. I decided to ignore this information because it is not mandatory (see https://community.openhab.org/t/huebridgehandler-and-huelightdiscoveryservice-error-further-auto-discovery-won-t-work/62693/).

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

openhab-bot commented 5 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/huebridgehandler-and-huelightdiscoveryservice-error-further-auto-discovery-won-t-work/62693/9

kaikreuzer commented 5 years ago

@kaikreuzer Can you please comment if we would like to change the "Hue binding" to work with a deCONZ emulated bridge?

The hue binding even discovers the openHAB hue emulation - so yes, whatever claims to be a hue bridge would be nice to be supported.