[OneWire] code improvements

eclipse-archived / smarthome

Eclipse SmartHome™ project

https://www.eclipse.org/smarthome/

Eclipse Public License 2.0

862 stars 787 forks source link

[OneWire] code improvements #6831

Closed J-N-K closed 5 years ago

J-N-K commented 5 years ago

better dynamic channel handling
add test to make sure all sensors types have associated thing-types
add test to make sure all thing types have labels for auto-discovery

Signed-off-by: Jan N. Klug jan.n.klug@rub.de

J-N-K commented 5 years ago

I have some more improvements in mind that are independent from this one. Should I add more commits or better create additional PR?

kaikreuzer commented 5 years ago

Independent PRs are usually the better choice. Please also make sure to give them a more explanatory title than "code improvements" as the PR title will be used for release notes (if it is an improvement that is more than some internal refactoring).