[OneWire] consolidate thing types and internal refactoring

eclipse-archived / smarthome

Eclipse SmartHome™ project

https://www.eclipse.org/smarthome/

Eclipse Public License 2.0

862 stars 787 forks source link

[OneWire] consolidate thing types and internal refactoring #6860

Closed J-N-K closed 5 years ago

J-N-K commented 5 years ago

cleanup handlers
automatic channel addition/removal based on sensor-type
reduce number of thing types ("digitalio", "digitalio2", "digitalio8", "counter2", "ibutton", "temperature" are now "basic")
better thing labels after discovery
better test coverage

This is the second to last PR for refactoring of the OneWire binding (#6842 being the last). With this PR configuration will become a lot easier for the users (only five thing-types (basic, ams, bms, ms-tx and edsenv and one bridge remain). All other configuration will be done on-the-fly depending on the sensor type.

J-N-K commented 5 years ago

@kaikreuzer, I think we‘ll not be able to get all OneWire changes merged before the transition. The BAE910 support is easy to change, there are only new files, Southwest have to be refactored but that is quite easy. This one and the other (#6482) are harder since a lot of existing files are touched. I can provide a new PR containing all changes (so I have to do the refactoring only once), but the commit history will be lost and it would become harder to review and we‘ll get over 1000 lines added. I’d that still a problem?

kaikreuzer commented 5 years ago

@J-N-K Please put your work here on hold - the transition is already ongoing, so this PR won't be merged anymore. The current OneWire code of the ESH master is included in https://github.com/openhab/openhab2-addons/pull/4625. So you should wait until this has been merged and you can then do further changes against https://github.com/openhab/openhab2-addons (under org.openhab namespace - it should be fairly easy to use Eclipse refactoring support to change your current local version of the code).