search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 787 forks source link

Extend usb serial discovery service to contain product ID … #6862

Closed YordanDZhelev closed 5 years ago

YordanDZhelev commented 5 years ago

For better differentiation between different USB devices UsbSerialDiscoveryService is extended to add usb_vendor_id and usb_product_id properties to every thing which represents USB device. Signed-off-by: YordanDZhelev zhelev.yordan@gmail.com

kaikreuzer commented 5 years ago

@YordanDZhelev This PR causes one test to fail now:

Tests in error: 
  UsbSerialDiscoveryServiceTest.testThingsAreActuallyDiscovered:139 » NullPointer
YordanDZhelev commented 5 years ago

@kaikreuzer is this PR going to be processed here? Is it too late?

kaikreuzer commented 5 years ago

Thanks @YordanDZhelev - yes, we can merge it here and I additionally ported the fix to https://github.com/openhab/openhab-core/pull/497.