search

eclipse-archived / smarthome

Eclipse SmartHome™ project
https://www.eclipse.org/smarthome/
Eclipse Public License 2.0
862 stars 783 forks source link

New rule engine: Rule failure event? #691

Open danchom opened 8 years ago

danchom commented 8 years ago

smhgit commented on Nov 4 Currently there are two events which are posted: RUNNING & IDLE. I thought of using them to give some notification to the user. The issue is that if there is a failure in the action execution it is not exposed. Is there currently a way to know if the execution has failed? (I thought of adding RuleStatusDetail to the IDLE event when it is posted or adding FAILURE event).

dnobel commented on Nov 5 I think what we first need here is the notification concept for ESH. This is discussed here https://www.eclipse.org/forums/index.php/t/1070058/ and there also is an initial PR eclipse#459 So I think we should skip the discussion for later. But in general it makes sense to have notifications for failures in rule execution.

dnobel commented on Nov 5 I will mark this stuff with the "enhancement" label. Means it will not be part of the initial PR and we have to move this issues later to ESH or start a forum discussion.

kaikreuzer commented 8 years ago

@smhgit: I am not completely sure what a "failure" exactly means in this context - I therefore assume we talk about unexpected exceptions happening in the module handlers.

In that situation, I would suggest to catch the exception, stop further execution of the rule and set its status to IDLE with a status details of the exception message.