eclipse-archived / unide

Eclipse Public License 1.0
29 stars 17 forks source link

Fix json schemas #21

Closed ameinhardt closed 6 years ago

ameinhardt commented 6 years ago

There are a few inconsistencies between json schema and online specification. I suggest to

ameinhardt commented 6 years ago

limits currently have one entry per lower/upper warn/error per measurement point. In the example of https://www.eclipse.org/unide/specification/#limits_process it shows an array. So should limits in measurement and process messages be arrays or single values?

fpatz commented 6 years ago

I think limits should be single-valued. Do you have use cases that demand multiple limits?

ameinhardt commented 6 years ago

for processes, there might be a different limit in the heating-up phase than for later production phase. Maybe we keep a limits array as an alternative to one constant value. The former has to be equal length to the corresponding measurements, though. That cannot be checked with schema, but maybe we could cover that with json path or other methods?

fpatz commented 6 years ago

No idea, honestly. It feels quite complex. My domain expertise is too limited to assess this properly.

ameinhardt commented 6 years ago

while reviewing the schemas, I also

ameinhardt commented 6 years ago

schemas updated and refactored to seperate folder: /ppmp/ppmp-schema