eclipse-arrowhead / core-java-spring

Eclipse Public License 2.0
28 stars 51 forks source link

HTTP-SECURE-JSON vs. HTTPS-SECURE-JSON #282

Closed marci543 closed 2 years ago

marci543 commented 3 years ago

Both HTTP-SECURE-JSON and HTTPS-SECURE-JSON interface names are present in the code. Service registry request should match the interfaces listed in service_interface table. https://github.com/eclipse-arrowhead/core-java-spring/blob/ae8d40e6e4887d04e3d617227887fdb2513829de/scripts/create_arrowhead_tables.sql#L99

Although here both versions seem to be accepted.

HTTP-SECURE is more often in the code (118 lines). The following lines contain HTTPS-SECURE-JSON:

$ ag HTTPS-SECURE-JSON core-java-spring/ sos-examples-spring/
core-java-spring/README.md
732:> **Note:** Valid `interfaceRequirements` name pattern: protocol-SECURE or INSECURE format. (e.g.: HTTPS-SECURE-JSON)
858:> **Note:** Valid `interfaces` name pattern: protocol-SECURE or INSECURE format. (e.g.: HTTPS-SECURE-JSON)
1115:> **Note:** Valid `interfaces` name pattern: protocol-SECURE or INSECURE format. (e.g.: HTTPS-SECURE-JSON)
1300:> **Note:** Valid `interfaces` name pattern: protocol-SECURE or INSECURE format. (e.g.: HTTPS-SECURE-JSON)
1414:> **Note:** Valid `interfaces` name pattern: protocol-SECURE or INSECURE format. (e.g.: HTTPS-SECURE-JSON)

sos-examples-spring/demo-exchange-rate-intercloud/demo-exchange-rate-intercloud-consumer/src/main/java/ai/aitia/demo/exchange_rate_consumer/Constants.java
10: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";

sos-examples-spring/demo-exchange-rate-intercloud/demo-exchange-rate-intercloud-provider/src/main/java/ai/aitia/demo/exchange_rate_provider/Constants.java
10: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";

sos-examples-spring/demo-car/demo-car-consumer/src/main/java/ai/aitia/demo/car_consumer/CarConsumerConstants.java
10: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";

sos-examples-spring/demo-car/demo-car-provider/src/main/java/ai/aitia/demo/car_provider/CarProviderConstants.java
12: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";

sos-examples-spring/demo-car-with-events/demo-car-consumer-with-subscribing/src/main/java/ai/aitia/demo/car_consumer_with_subscribing/CarConsumerConstants.java
10: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";

sos-examples-spring/demo-car-with-events/demo-car-provider-with-publishing/src/main/java/ai/aitia/demo/car_provider_with_publishing/CarProviderWithPublishingConstants.java
12: public static final String INTERFACE_SECURE = "HTTPS-SECURE-JSON";
borditamas commented 3 years ago

Both interface expression is a valid one according to the current requirements.

tsvetlin commented 3 years ago

@borditamas We should change HTTPS to HTTP.

rbocsi commented 3 years ago

bump

MaGaMeGa commented 3 years ago

Resolved by rbocsi at arrowhead-f/core-java-spring branch. Waiting for review and close.