search

eclipse-aspectj / aspectj

Other
303 stars 86 forks source link

Fix several bugs #212

Closed kriegaex closed 7 months ago

kriegaex commented 1 year ago

This PR should, step by step, fix all problems mentioned in #211, not just the original one, but also the other ones mentioned in comments. The plan is to push and build commit by commit in order to find out if the bugfixes actually break existing tests which falsely expect faulty behaviour.

I might force-push commits, adding other tests or editing commit messages, referring to future issues I might open in order to split the catch-all issue #211 into distinct issues per topic, which later we can also refer to from release notes.

kriegaex commented 1 year ago

@aclement, I am quite satisfied with the other commits in this PR, but for commit a70ffd3 even more than for the others I would like to get your feedback. Please read the lengthy commit comment and recommend a way to handle this situation. Thank you so much.