eclipse-aspectj / aspectj

Other
300 stars 86 forks source link

Implement source location matching for weave messages in XML tests #220

Closed kriegaex closed 7 months ago

kriegaex commented 1 year ago

WIP (work in progress).

@aclement: For now, I committed the solution with extended output via ISourceLocations, see also https://github.com/eclipse/org.aspectj/issues/218#issuecomment-1407720246. In order for this to work, I had to adjust several tests expecting an exact line-by-line console output instead of selectively matching on weave messages. If I would change this to not passing through source locations but rather directly using file names and lines, I could revert the separate commit updating the expected test outputs, because then the change would be transparent, but also contain less specific information, both internally and on the console.

Closes #218.