search

eclipse-aspectj / aspectj

Other
303 stars 86 forks source link

fix NPE when using LTW cache; fix TODO in SimpleCache#getAndInitialize #286

Closed KimmingLau closed 9 months ago

KimmingLau commented 9 months ago

1.write SAME_BYTES to cacheMap when wovenbytes is null
2.fix TODO in SimpleCache#getAndInitialize, use Optional to help indicating case in which Hit cache but need to return null

kriegaex commented 9 months ago

Why did you close the PR? Your fix has neither been reviewed nor merged.

KimmingLau commented 9 months ago

Sorry for that I found I missed a commit, and I've created an other PR

kriegaex commented 9 months ago

Oh sorry, I was confused, only briefly opening my messages on the road.

Next time, please simply commit on top of the existing PR, or even force-push broken commits. No need to start over. 🙂

KimmingLau commented 9 months ago

Ok, I see