search

eclipse-aspectj / aspectj

Other
291 stars 84 forks source link

Improve ClassPathManager performance, caching unfound entries #308

Closed harrisric closed 5 months ago

harrisric commented 5 months ago

Fixes #306.

kriegaex commented 5 months ago

@harrisric, you do not seem to have signed the Eclipse Contributor Agreement (ECA) yet. Please do that, otherwise I cannot accept your PR, even after verifying it technically and functionally. Thank you in advance.

kriegaex commented 5 months ago

@harrisric, please note that I added a test in a new commit, then reordered the commits and force-pushed after slightly modifying your commit message. Does that look OK to you?

The ECA check now also passes, either due to my co-authorship or because you signed the ECA in the meantime.

harrisric commented 5 months ago

@kriegaex yes, that looks good to me, and yes I have signed the ECA since the PR was first added. Thanks!