search

eclipse-aspectj / eclipse.jdt.core

Aspectj JDT Core
Eclipse Public License 2.0
17 stars 6 forks source link

JDT Core for Java 15 + 16 #4

Closed kriegaex closed 3 years ago

kriegaex commented 3 years ago

This PR starts at the commit which was last merged in April 2020 for the AspectJ 1.9.6 release, using the previous upstream merge commit 48c3f76 as a starting point. First I imported the previous version from the JDT Core Shadows repository, minus whitespace changes.

Then, step by step, I merged in upstream changes concerning Java 15+16 and refactored the project into a Maven build, transitioning away from Ant. The artifact also is deployed separately now, no longer copied into a local AspectJ working directory. Instead, AspectJ consumes it as a regular external dependency.

aclement commented 3 years ago

Theres only a couple of things I really wonder about before merging:

We should have a further (separate) commit that updates the README with what this module really is and what anyone should do if trying to bring it up to date.

kriegaex commented 3 years ago
  • were we always tweaking the debug flag on that I commented on above? That isn't something you are doing differently? If it was always there wish there was a comment as to why :)

I commented on that already. I can revert if you like. Update: done, compiles fine.

  • I haven't built this myself to verify the different way the APT module is being handled compared to 'before' but I presume you have tried it and I really hope we have some tests for it that are passing with this JDT Core.

I tried to build with both Maven and Eclipse IDE, yes. What is used in AspectJ is always the Maven build artifact, though. So I do not know if the two are exactly the same. The Eclipse build IMO is mainly for active development, fixing bugs, resolve merge conflicts and see if it still compiles.

We should have a further (separate) commit that updates the README with what this module really is and what anyone should do if trying to bring it up to date.

Actually, I struggled so hard to build AspectJ, JDT Core and AJDT on my workstation and I wrote tons of e-mails about it during the process. I did not update any developer information like read-me files, but I did comment a lot in Maven POMs. For now, I do not see any other contributors than you and myself, and if there are any, I would certainly support them. I am frankly just lazy to do more writing and documentation at present and do not wish that to become a PR merging blocker, because before the developer documentation was just as inadequate as it is now. Now we have a Maven build, a place to deploy to, extensive commit comments. I do hope that for now this is enough.

aclement commented 3 years ago

I am frankly just lazy to do more writing and documentation at present and do not wish that to become a PR merging blocker

Nope, it isn't a blocker for merge. But if something isn't written down, it is just moving the challenge of 'don't know what to do to upgrade this project' from me to you, and you become the blocker for future updates instead.