search

eclipse-aspectj / eclipse.jdt.core

Aspectj JDT Core
Eclipse Public License 2.0
17 stars 6 forks source link

Exclude more stuff from build artifact (Apache Felix, Eclipse JFace) #9

Closed kriegaex closed 3 years ago

kriegaex commented 3 years ago

@aclement noticed that there was stuff inside aspectjtools.jar which in 1.9.6 was not there. I thought it was just new content from JDT dependencies, but actually Apache Felix and Eclipse JFace existed in the dependencies before, but were explicitly excluded in the old Ant build. I missed to port that one line to Maven - good catch, Andy!

Update: I deployed a new artifact on GH Packages already, so you can try and build AspectJ again and see the difference in aspectjtools.jar. It is still a bit bigger than in 1.9.6, but I checked and guess that this time it is just new or bigger classes in previously included packages.

aclement commented 3 years ago

Glad we could work out what it was, thanks for digging in.

aclement commented 3 years ago

I suppose ideally somewhere we should have a test that verifies no unexpected packages sneak through