search

eclipse-basyx / basyx-aas-web-ui

Web-based user interface for managing and interacting with Asset Administration Shells (AAS)
MIT License
9 stars 7 forks source link

[BUG] Authorization headers is changed even if tokenManager is disabled #120

Open StenGruener opened 3 days ago

StenGruener commented 3 days ago

Describe the bug In our setup we use basic auth = username/pass protected endpoints. New versions of web-ui break do not support this auth, since Authorization header is always set to Bearer even if tokenManager is disabled

To Reproduce Steps to reproduce the behavior:

  1. Select no token
  2. Do requests
  3. Observe "Authorization: Bearer " header in requests

Expected behavior I expect that the Authorization Headers part is not changed/set by gui if tokens are disabled.

Additional context I guess that a check for this.authStore.getAuthEnabled() needs to be added somewhere here: https://github.com/eclipse-basyx/basyx-aas-web-ui/blob/2cdcc2aa0032f980958439c1130cf6ffb50e819a/aas-web-ui/src/mixins/RequestHandling.ts#L16

aaronzi commented 3 days ago

Hi @StenGruener,

thank you for informing us about this oversight. We will have a look and will implement this fix.