eclipse-basyx / basyx-databridge

Eclipse Public License 2.0
11 stars 18 forks source link

Adds support for multiple datasinks in one route #300

Closed Aegid1 closed 4 months ago

Aegid1 commented 7 months ago

fixes #1

FrankSchnicke commented 7 months ago

Thanks a lot for providing this PR! Would it be possible to sign the Eclipse Contributor Agreement?

Aegid1 commented 7 months ago

Thanks a lot for providing this PR! Would it be possible to sign the Eclipse Contributor Agreement?

Sure! I updated the eclipse validation status.

FrankSchnicke commented 7 months ago

I see that the CI is failing at the examples. It is possible that you changed something that would break backwards compatibility?

Aegid1 commented 7 months ago

Ah sure! I forgot to adjust the routes.json in the databridge.examples. Thank you for the hint!

FrankSchnicke commented 6 months ago

Sorry for the delayed response, due to Hannover Fair we were quite busy. Thanks a lot for updating the PR!

To ensure I'm understanding it right, the transformer "jsonataBatteryStatus" would be mapped to "sink://tendobot/BatteryStatus", "jsonataSpeed" to "sink://tendobot/Speed" etc.?

Aegid1 commented 6 months ago

Dont worry :). Exactly! I have just seen that a check was not successful. Do you know why that is?

jannisjung commented 5 months ago

I have added a PR #308 built upon this PR with an improved datasink mapping configuration to avoid breaking changes

aaronzi commented 4 months ago

Those changes are now part of #308. Since this PR is already merged I will close this one.