search

eclipse-basyx / basyx-java-sdk

java-sdk
MIT License
25 stars 32 forks source link

Allow uppercase dataTypes and set them to lowercase #290

Closed tilman19 closed 1 year ago

tilman19 commented 1 year ago

This will allow to mitigate bugs like https://github.com/admin-shell-io/submodel-templates/issues/27, even though a warning will be presented to the user. In general this will make reading aasx files more robust, similar to https://bugs.eclipse.org/bugs/show_bug.cgi?id=571725.

FrankSchnicke commented 1 year ago

Thank you very much for providing this PR. Currently, the CI is failing. From taking a look at it, I think the issue is that not the complete name has to be converted to lower case, only the first letter. Right now, e.g., "dateTime" is converted to "datetime".

Would it be possible to update the PR?

tilman19 commented 1 year ago

Adjusted the PR and added a test for types like dateTime, integer and Integer

FrankSchnicke commented 1 year ago

Thank you very much!