eclipse-basyx / basyx-java-server-sdk

MIT License
55 stars 45 forks source link

No MQTT events for PUT-Requests? #300

Closed de-ich closed 2 months ago

de-ich commented 4 months ago

Hello,

I was testing the MQTT event feature of the submodel repository. When I update an existing Property via a PATCH request, it seems that no MQTT event is sent.

I used the following setup:

eclipsebasyx/aas-environment:2.0.0-SNAPSHOT

Best regards Matthias

mdanish98 commented 4 months ago

Hi @de-ich ,

Thanks for raising this issue. Would it be possible for you to share the configurations you used in this? like application.properties etc

de-ich commented 4 months ago

See https://github.com/eclipse-basyx/basyx-java-server-sdk/issues/299#issuecomment-2136777055

aaronzi commented 4 months ago

Hello @de-ich,

I can't reproduce that issue. I also have to say I'm a bit confused. In #299 you say that updating Properties works fine. Properties are updated via PATCH in the AAS Web UI. I also verified that this works and triggers an MQTT event. Could you please clarify what the issue is here?

de-ich commented 3 months ago

Hello @aaronzi,

you are right - I labeled one of my requests incorrectly and got confused. The problem does not seem to be with PATCH requests but with PUT requests:

When I update a Property (value) with a PATCH request, an MQTT event is generated correctly. However, when I replace the complete property with a PUT request, no MQTT event is generated.

aaronzi commented 3 months ago

Alright ;) We will have another look at this.

aaronzi commented 3 months ago

Update: This is a Bug. We are currently missing one line of code that should have been there for this feature to work. We will create a PR for this immediately.

aaronzi commented 2 months ago

The PR is merged now