search

eclipse-basyx / basyx-java-server-sdk

MIT License
60 stars 47 forks source link

Set file name on file download sme #458

Closed ShehriyarShariq-Fraunhofer closed 2 months ago

ShehriyarShariq-Fraunhofer commented 2 months ago

Description of Changes

  1. In the SubmodelRepositoryApiHTTPController, added a Content-Disposition header in the getFileByPath method response, so that files that are downloaded from the API have a file-specific name once downloaded. Previously all and any files were downloaded under the name "attachment".
  2. Updated the test for getFile in SubmodelRepositorySubmodelHTTPTestSuite.java by also adding a fileName assertion check.

Closes #412

mateusmolina-iese commented 2 months ago

@ShehriyarShariq-Fraunhofer, can you please write "Closes #412" in the ticket description?