eclipse-basyx / basyx-python-sdk

MIT License
60 stars 28 forks source link

adapter.xml: rename `XMLConstructables.GLOBAL_REFERENCE` #253

Closed jkhsjdhjs closed 7 months ago

jkhsjdhjs commented 7 months ago

GlobalReference has been renamed to ExternalReference in V3, but this enum member has been missed in the rename.

This is technically a breaking change (which is why I pushed it to a separate branch), but I doubt that anyone really uses the deserialization of single objects, most people can't even use the normal deserialization due to wrong XML namespaces and OPC relationship types.

s-heppner commented 7 months ago

Good eye! LGTM, I say we merge this into main and simply mention it in the next release. As you say, this shouldn't affect anyone in practice.