Closed dofmind closed 2 months ago
LGTM and thanks for adding tests!
@dofmind Could you add the two new configuration options to the bluechi-controller.conf.5.md? Sorry, I missed that during the previous review. Then, I think, the PR is ready to merge.
@dofmind Could you add the two new configuration options to the bluechi-controller.conf.5.md? Sorry, I missed that during the previous review. Then, I think, the PR is ready to merge.
This PR already has them. Did I miss anything?
@dofmind Could you add the two new configuration options to the bluechi-controller.conf.5.md? Sorry, I missed that during the previous review. Then, I think, the PR is ready to merge.
This PR already has them. Did I miss anything?
No, but I did. Sorry about that.
This PR is an update of https://github.com/eclipse-bluechi/bluechi/pull/870
The main difference is that the code is simplified by using microseconds in last_seen instead of the struct timespec. It updates last_seen in node_method_register() to prevent the node disconnecting right now when last_seen is 0 or too old. Additionally, it handles disconnected nodes by calling node_disconnected() instead of controller_remove_node(). Otherwise an error will occur.
Fixes: https://github.com/eclipse-bluechi/bluechi/issues/857