Closed pokgak closed 5 years ago
Thanks! Great work. I will need some time to try it out. So my current forecast would be, that if you correct the minors above, I merge the PR next Tuesday. Or do you need it faster?
In the 2.0.x branch, the LinkFormat
COUNT
and PAGE
seems to be missing.
Do you prepare a additional PR for that to make the changes of this PR working?
I pushed some fixup commits to address your comments. The check should be all green again after squashing.
Do you prepare a additional PR for that to make the changes of this PR working?
Opened PR eclipse/californium#964 to address this.
I will need some time to try it out. So my current forecast would be, that if you correct the minors above, I merge the PR next Tuesday. Or do you need it faster?
Tuesday sounds good. I'm not in a hurry to use this, so you can take your time reviewing :)
The "Signed-off-by:" is missing in the "fixup!" commits. Please don't waste your time, just squash all your commits to one, sign the result and force push them to your branch.
Squashed. Checks all green. Not used to this workflow. I will keep that in mind next time. Thank you!
could you please squash all your commits (from 5af644a4cf to d2e67fabafa) into one? And then rebase that commit to the current 2.0.x head (we need to fix a executor dependency). Afterwards "push forced" it to your branch, then I can merge it. Thanks in advance.
Squashed and rebased.
Thanks!
This PR updates cf-rd to the latest resource directory draft (version 20).