search

eclipse-californium / californium.tools

Californium project
Other
59 stars 57 forks source link

Update cf-rd to draft version 20 #34

Closed pokgak closed 5 years ago

pokgak commented 5 years ago

This PR updates cf-rd to the latest resource directory draft (version 20).

boaks commented 5 years ago

Thanks! Great work. I will need some time to try it out. So my current forecast would be, that if you correct the minors above, I merge the PR next Tuesday. Or do you need it faster?

boaks commented 5 years ago

In the 2.0.x branch, the LinkFormat COUNT and PAGE seems to be missing. Do you prepare a additional PR for that to make the changes of this PR working?

pokgak commented 5 years ago

I pushed some fixup commits to address your comments. The check should be all green again after squashing.

Do you prepare a additional PR for that to make the changes of this PR working?

Opened PR eclipse/californium#964 to address this.

I will need some time to try it out. So my current forecast would be, that if you correct the minors above, I merge the PR next Tuesday. Or do you need it faster?

Tuesday sounds good. I'm not in a hurry to use this, so you can take your time reviewing :)

boaks commented 5 years ago

The "Signed-off-by:" is missing in the "fixup!" commits. Please don't waste your time, just squash all your commits to one, sign the result and force push them to your branch.

pokgak commented 5 years ago

Squashed. Checks all green. Not used to this workflow. I will keep that in mind next time. Thank you!

boaks commented 5 years ago

could you please squash all your commits (from 5af644a4cf to d2e67fabafa) into one? And then rebase that commit to the current 2.0.x head (we need to fix a executor dependency). Afterwards "push forced" it to your branch, then I can merge it. Thanks in advance.

pokgak commented 5 years ago

Squashed and rebased.

boaks commented 5 years ago

Thanks!