eclipse-californium / californium

CoAP/DTLS Java Implementation
https://www.eclipse.org/californium/
Other
728 stars 364 forks source link

Add "SPDX-License-Identifier: EPL-2.0" #2048

Open boaks opened 2 years ago

boaks commented 2 years ago

I currently plan to add

SPDX-License-Identifier: EPL-2.0

to all file headers.

Any opinions? Objections?

boaks commented 1 year ago

In the meantime I updated the license_header_template.txt (see PR #2097 ).

The result is "SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause".

I would just got to edit the headers module by module to add that line and remove the " All rights reserved. ". That mainly causes more work, if someone has middle or larger ongoing work on existing files. Though it edits only the header, such changes should be easy to apply automatically.

@sbernard31 is it OK for you that I start to edit the headers? You may need to apply that to your branch "csm".

sbernard31 commented 1 year ago

@sbernard31 is it OK for you that I start to edit the headers? You may need to apply that to your branch "csm".

What would be other alternatives ?

boaks commented 1 year ago

Just postpone to edit the headers.

sbernard31 commented 1 year ago

postpone but until when ?

To be totally transparent, currently

So currently on my side this is completely in pause. If nothing changes about this, I plan to explore other way than contributing to Californium.

But of course, if :

I'm OK to try.

So I guess we should finish this discussion first and then we can have a plan for this topic ? or postpone is just not an option.

boaks commented 1 year ago

As I proposed in a e-mail:

Either use a "feature branch" or try to use a separate "module" for this TCP WIP. Since you started to work on it, the scope expanded and expanded. I gave a lot of answers, but it seems, that this answers didn't help. I'm not the only one, who may have a look at this TCP work and may give additional answers.

boaks commented 1 year ago

or postpone is just not an option.

It's up to you to decide, if the TCP work should be a feature branch (then these header changes should mainly be handled with rebasing), a separate module, or that TCP work itself is postponed or abandoned.

Adding "SPDX-License-Identifier:" isn't that urgent for me, it's more a question, when spending the time. Maybe I start with the other, not TCP affected, modules.

sbernard31 commented 1 year ago

Adding "SPDX-License-Identifier:" isn't that urgent for me, it's more a question, when spending the time. Maybe I start with the other, not TCP affected, modules.

if you can, this is maybe better to postpone all header in californium-core/ element-connector/ element-connector-tcp-netty until we clarify the coap+tcp situation.

More or less what I propose with :

So I guess we should finish this discussion first and then we can have a plan for this topic ?

boaks commented 1 year ago

if you can

Sure, then I will edit the other headers.