search

eclipse-californium / californium

CoAP/DTLS Java Implementation
https://www.eclipse.org/californium/
Other
730 stars 367 forks source link

fix: account for removal of disallowed characters in ipv6 scopes #2164

Closed hasheddan closed 1 year ago

hasheddan commented 1 year ago

Updates the StringUtil tests to account for the removal of disallowed characters in ipv6 scopes. Previously tests would fail if one of these characters was present.

boaks commented 1 year ago

Thanks for the PR! If you like, please sign an ECA. If you don't like, I convert this into an issue and implement a fix on my own ;-).

boaks commented 1 year ago

On a first try, it may be an error in the eclipse verification stuff. I will need a moment to analyze an try to sort it out.

hasheddan commented 1 year ago

@boaks thanks! Let me know if you need me to update anything :)

boaks commented 1 year ago

My result:

You have a valid ECA with the e-mail address of the commit.

Sometimes the Eclipse Validation takes some time. I already tried it twice. I will retry it tomorrow before I start the release. If that still fails, I will check it again, document it and merge it before the release.

boaks commented 1 year ago

LGTM

done :-)