search

eclipse-californium / californium

CoAP/DTLS Java Implementation
https://www.eclipse.org/californium/
Other
730 stars 367 forks source link

OSCORE: Improvements to functionality for secure context re-generation #2185

Closed rikard-sics closed 1 year ago

rikard-sics commented 1 year ago

Two modifications have been done to the Appendix B.2 functionality for securely re-generating contexts:

boaks commented 1 year ago

testServerInitiatedRederivation

fails "on my machine".

rikard-sics commented 1 year ago

testServerInitiatedRederivation

fails "on my machine".

Thanks for the quick feedback. Perhaps I messed something up while cleaning up the code. I will recheck and fix it.

rikard-sics commented 1 year ago

Alright, I have now fixed the issue. The problem was one leftover line in the JUnit test testServerInitiatedRederivation that was checking the payload content for a specific value, while just checking the code is sufficient.

boaks commented 1 year ago

The coding is LGTM. Should the points in the interoperability discussion be included in this PR or should this PR be merged and the left issues are addressed later?

rikard-sics commented 1 year ago

The coding is LGTM. Should the points in the interoperability discussion be included in this PR or should this PR be merged and the left issues are addressed later?

Yes, sounds good to merge this one as is.

I will create separate new PRs for the "osc" target attribute, and the cf-plugtest-checker issues that we also discussed as part of the interop tests.

rikard-sics commented 1 year ago

I squashed the commits.