search

eclipse-californium / californium

CoAP/DTLS Java Implementation
https://www.eclipse.org/californium/
Other
729 stars 367 forks source link

Remove/deprecate crop rotation deduplication algorithm #2300

Open jvermillard opened 1 week ago

jvermillard commented 1 week ago

After some testing, I don't see a case where the crop rotation de-duplicator is better compared to the mark and sweep default algorithm. Also the documentation is quite sparse, but states "This deduplicator is probably inferior to the {@link SweepDeduplicator}." and doesn't state when it could be useful.

Since the low (no?) number of issue about this specific dedup algorithm, I think it's not really used. So I propose we deprecate/delete it

boaks commented 1 week ago

I agree. I guess it's a left over from the very begin. I also don't use it.

boaks commented 1 week ago

Removed in branch main / 4.0.x