org.polarsys.capella.core.ui.search (API) is strongly dependant on org.polarsys.capella.core.ui.search.result, which isn't exported

eclipse-capella / capella

Open Source Solution for Model-Based Systems Engineering

https://mbse-capella.org

Eclipse Public License 2.0

232 stars 96 forks source link

org.polarsys.capella.core.ui.search (API) is strongly dependant on org.polarsys.capella.core.ui.search.result, which isn't exported #2732

Open ebausson-obeo opened 11 months ago

ebausson-obeo commented 11 months ago

Extending org.polarsys.capella.core.ui.search is difficult because it is highly coupled to some of its unexported subpackages, among which is .result

It might be a decent idea to export the following packages as API or internal:

org.polarsys.capella.core.ui.search.match
org.polarsys.capella.core.ui.search.result
org.polarsys.capella.core.ui.search.result.handlers
org.polarsys.capella.core.ui.search.searchfor
org.polarsys.capella.core.ui.search.searchfor.item Thanks for your consideration.

ebausson-obeo commented 11 months ago

This evolution might be more valuable if those classes used internal getters instead of directly using their parameters in functions, allowing easier extension.