Fix disable.nebula.richtext property.

jeffallen commented 1 year ago

In v6.1.0, I am trying to work around #2316 by using the line

disable.nebula.richtext=true

in my config.ini file. When I do that, I get errors at runtime from this call to setBaseHREF.

I have also found that it is impossible to build v6.1.0 right now, because Sirius 7.1.0 has gone missing from the distribution site. Here is the patch I needed to make to be able to build this at all:

diff --git a/releng/plugins/org.polarsys.capella.targets/full/capella.target-definition.targetplatform b/releng/plugins/org.polarsys.capella.targets/full/capella.target-definition.targetplatform
index 56d2674f9b..fedd4e6d0b 100644
--- a/releng/plugins/org.polarsys.capella.targets/full/capella.target-definition.targetplatform
+++ b/releng/plugins/org.polarsys.capella.targets/full/capella.target-definition.targetplatform
@@ -64,7 +64,7 @@ location Xerces-2.12.2 "https://download.eclipse.org/modeling/gmp/gmf-runtime/up
        org.apache.xerces
 }

-location sirius "https://download.eclipse.org/sirius/updates/stable/7.1.0-S20230302-034329/2021-06" {
+location sirius "https://download.eclipse.org/sirius/updates/stable/7.2.0-S20230616-100446/2023-03" {
        org.eclipse.sirius.doc.feature.feature.group
        org.eclipse.sirius.doc.feature.source.feature.group
        org.eclipse.sirius.runtime.source.feature.group

I am hoping that maybe this dependency is cached on the build server, and that this PR will build anyway.

eclipse-capella-bot commented 1 year ago

:rocket: Build master-PR-2740-1 started!

eclipse-capella-bot commented 1 year ago

:disappointed: Build master-PR-2740-1 failed!

jeffallen commented 1 year ago

This build failed because of the missing dependency I mentioned above. Do one of the Capella maintainers know people on the Sirius team, in order to solve this first?

eclipse-capella-bot commented 1 year ago

:rocket: Build master-PR-2740-2 started!

pdulth commented 1 year ago

Hi, Looks good yes. I think the build failed due to your master branch being not up-to-date with the intended target version.

If you want to fix for the nightly/7.0 version, can you rebase your master branch. Normally it shall work as the 7.3.0 sirius version exits (and rebase the fix-no-richtext from it)
If you try to build a 6.x, you can start over the v6.1.0 tag, and update sirius to the released one like you did.

eclipse-capella-bot commented 1 year ago

:disappointed: Build master-PR-2740-2 failed!

jeffallen commented 1 year ago

What I want is for rich text editing to work on Linux with v6.1.x. What I'm willing to settle for is the ability to at least turn off rich text editing in some hypothetical to-be-released v6.1.1. So that's why I based this PR on tag V6.1.0.

jeffallen commented 1 year ago