search

eclipse-cbi / dockerfiles

Various Dockerfiles for building stuff @ Eclipse
Eclipse Public License 2.0
2 stars 6 forks source link

Add required dependencies for hugo extended #16

Closed sdirix closed 3 years ago

sdirix commented 3 years ago

When running the hugo_extended image hugo failed with hugo: not found.

The cause is that the hugo extended binary requires certain libstdc++ and glibc libraries to work. These are now installed into the new separate alpine-based image for hugo extended.

sdirix commented 3 years ago

@mbarbero We could also use a different base image which already includes all required libraries. Let me know what you prefer.

mbarbero commented 3 years ago

Thanks for the contribution and sorry for the delay. I'm catching up on leftovers from the holiday season ;)

sdirix commented 3 years ago

@mbarbero No worries, I didn't even expect you to look so early at this PR because of the holiday season. Thanks for the review!

Do you by chance know how I can force the Eclipse Jenkins to use the new image? My build still uses the old version of eclipsecbi/hugo_extended:0.78.1. Only when I manually specify the digest, i.e. image: eclipsecbi/hugo_extended:0.78.1@sha256:636121c747261b2515f0924d787a4743f73e7e8273c47908f4726f0b065101cd, it will use the latest one. However I would rather not hard code it like this in the Jenkinsfile.

mbarbero commented 3 years ago

Do you by chance know how I can force the Eclipse Jenkins to use the new image? My build still uses the old version of eclipsecbi/hugo_extended:0.78.1. Only when I manually specify the digest, i.e. image: eclipsecbi/hugo_extended:0.78.1@sha256:636121c747261b2515f0924d787a4743f73e7e8273c47908f4726f0b065101cd, it will use the latest one. However I would rather not hard code it like this in the Jenkinsfile.

Sure, just add imagePullPolicy: Always to the container configuration (see https://kubernetes.io/docs/concepts/containers/images/#updating-images for details)

sdirix commented 3 years ago

Thanks a lot for the quick answer! :smile: