search

eclipse-cbi / jiro

Jenkins infrastructure for projects hosted by the Eclipse Foundation
Other
10 stars 37 forks source link

feat: add github-scm-trait-notification-context plguin to JKube instance #286

Closed manusa closed 1 year ago

manusa commented 1 year ago

feat: add github-scm-trait-notification-context plguin to JKube instance

In order to be able to customize the GitHub checks produced by the github-branch-source plugin, the github-scm-trait-notification-context needs to be present in order to be able to modify the other plugin's behavior.

Configuration of the check/notification message is especially critical when more than one job is run for a same PR, since the status/check of one Job/Pipeline will overwrite the status/check of the other one.

Relates to:

manusa commented 1 year ago

As an alternative (AFAIU and considering I haven't tried this plugin ever -maybe I'm wrong about how things work-), I'd propose to include this plugin by default. GitHub PR integration for projects with more than a single job will likely require it.

fredg02 commented 1 year ago

github-scm-trait-notification-context plugin has been installed.

So far, there hasn't been widespread demand for this plugin. If that changes, we will reconsider to add it to the list of default Jenkins plugins.

manusa commented 1 year ago

Works like a charm: image

It might be interesting to document this in the Wiki. I can do this if you think it might be interesting for other users.