eclipse-cbi / macos-notarization-service

REST Service to notarize macOS application bundles and DMG
Eclipse Public License 2.0
5 stars 3 forks source link

Improve release workflow #257

Closed netomi closed 10 months ago

netomi commented 10 months ago

This fixes #255 .

This PR includes various improvements:

In order to make a release, just trigger the release workflow manually. The workflow will automatically setup the version for the release, tag, upload the release and bump the version to the next development version afterwards.

The release is prepared as draft, once everything is fine, you can publish it.

I tested the workflow extensively in my own fork, but cleaned up all generated tags / releases after it was finally successful. In order for the workflow to succeed, various things have to be setup correctly in the fork, so running the workflow as is in my fork will eventually fail. So after the workflow was working I modified the branch for the PR to the eclipse-cbi version and squashed all commits.

Edit: I have now run the release workflow in my fork with necessary changes (https://github.com/netomi/macos-notarization-service/commit/ce51ff04021ac4de3a1974159a9df36896076ba4): https://github.com/netomi/macos-notarization-service/actions/runs/6670304472 , the workflow just failed in the last step, uploading the artifacts to the draft release as the artifacts were already there (from a previous run).

Resulting in this release: https://github.com/netomi/macos-notarization-service/releases/tag/v1.2.1 Pom is updated afterwards: https://github.com/netomi/macos-notarization-service/commit/d1502737d76208060479ec2a78d0366d9552d8f8

Using the maven release plugin is a bit of a pain. In the long run we should use jreleaser and also get rid of the release drafter imho.