eclipse-cbi / macos-notarization-service

REST Service to notarize macOS application bundles and DMG
Eclipse Public License 2.0
5 stars 2 forks source link

Use jreleaser, remove release-drafter. #279

Closed netomi closed 7 months ago

netomi commented 8 months ago

This fixes #263 .

The release workflow has been updated to use the latest version of jreleaser. Additional changes:

aalmiray commented 8 months ago

The BINARY distribution type is supposed to be used for platform specific executables. If the project provides a Java based binary then the JAVA_BINARY distribution type is preferred, which is also the default value.

https://jreleaser.org/guide/latest/concepts/distributions/binary.html

https://jreleaser.org/guide/latest/concepts/distributions/java-binary.html

The choice of distribution type determines which other features may be used later, such as package managers.

netomi commented 8 months ago

marking as draft, doing some tests.

netomi commented 8 months ago

Finally got it working: https://github.com/netomi/macos-notarization-service/actions/runs/7144907502

Need to cleanup the PR and squash commits.

netomi commented 7 months ago

cleaned up PR, added additional checks for the release workflow:

netomi commented 7 months ago

An example run of the release workflow in my fork: https://github.com/netomi/macos-notarization-service/actions/runs/7153981992

Resulting in this release: https://github.com/netomi/macos-notarization-service/releases/tag/v1.3.0