eclipse-cbi / macos-notarization-service

REST Service to notarize macOS application bundles and DMG
Eclipse Public License 2.0
5 stars 2 forks source link

feat: improve error handling during submission #294

Closed netomi closed 6 months ago

netomi commented 7 months ago

This PR improves error handling when a submission fails.

In some cases, calling notarytool fails with an error as some license agreements need to be manually accepted. The tool will print this to stderr. Parsing the output from the tool in such cases resulting in an exception as the captured stdout was empty and a generic error message was returned.

Now, if an exception is thrown during parsing, the error output is captured and used for the returned value so that you immediately know whats going on.