search

eclipse-cbi / targetplatform-dsl

Target Platform Definition DSL and Generator
Eclipse Public License 2.0
76 stars 38 forks source link

Fix whitespace and remove useless feature metadata in maven targets #136

Closed Bananeweizen closed 1 year ago

Bananeweizen commented 1 year ago

All other parts of the generated target use an indentation of 2 spaces. Use the same in the Maven part. Also remove the useless metadata from the generated (optional) feature. There is no need to have those tags, and the generated nonsense data is end-user visible.

Attention reviewers: You may need to enable whitespace display in whatever review tool you use.

merks commented 1 year ago

Sorry, I meant to look at this today but forgot. I see there are test failures though...

merks commented 1 year ago

Please rebase and investigate the test failures. You should be able to do a local Tycho build to reproduce any problems ahead of time:

image

Bananeweizen commented 1 year ago

Thanks for the friendly reminder. After you fixed the IDE crash I was now able to get into the normal test cycle and noticed one more inconsistency in the nesting of the indentation. All fixed now.