Closed ndoschek closed 1 year ago
The last commit is missing the Contribution on behalf
message.
Thank you @sgraband for your review! I amended the last commit message, and I will now have a look into the issue with the trace server you mentioned.
Hi again @sgraband,
I double checked and the trace server works for me in both the browser and electron use case.
I downloaded the zipped trace server and then set the path to the tracecompass-server executable (e.g. /home/nina/Clients/OpenSource/CDTCloud/tmp-tracecompass/trace-compass-server-latest-linux.gtk.x86_64/trace-compass-server/tracecompass-server
).
Edit: As discussed with you offline, I also updated the server download script to ensure that the newest tracecompass-server version is pulled on yarn tracecompass-server:download
.
Thanks for the upgrade. Shouldn't the upgrade go to the latest Theia community release first which 1.37.x instead of the latest Theia release 1.38.x?
Please let me know.
@sdirix ?
@bhufmann is right, in general we want to base on the latest community release, which was 1.37.
However Theia Blueprint itself is on a monthly schedule anyway and already available for 1.38 (the links to older versions are not easy to find to download). As the update work was already done I would be fine with skipping the community release this time and going straight to 1.38. Then we return to community release based releases with the next community release.
@bhufmann Is there some specific constraint for which you would like to see CDT Cloud Blueprint to stay on 1.37 instead of 1.38? If there is a specific technical constraint so that for example trace compass works better with 1.37 then we should go to that version instead.
@bhufmann Is there some specific constraint for which you would like to see CDT Cloud Blueprint to stay on 1.37 instead of 1.38? If there is a specific technical constraint so that for example trace compass works better with 1.37 then we should go to that version instead.
No, there is no specific constraint that I know of. However, we just uplifted the theia-trace-extension
specifically to Theia 1.37 instead of 1.38 knowing that cdt-cloud-blueprint
would be based on the community release. I'm ok though to keep this uplift to 1.38 if there are no issues with keeping the trace extension on 1.37 for now.
@bhufmann Thanks for the uplift. I think it's worth it already simply to list it at https://theia-ide.org/releases/ :+1:
If the 1.37 version of trace compass works with Theia 1.38 without problems then I would now keep it that way. For next time we'll be more careful to correctly align with the community release again.
@sdirix I ran the tests locally, and they work for me (on linux) without any issues. Could you please trigger the build checks again? TIA
What it does
request
dependency for tracecompass-server-downloadContributed on behalf of STMicroelectronics
Signed-off-by: Nina Doschek ndoschek@eclipsesource.com