search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
31 stars 41 forks source link

Support allThreadsStopped marker on StoppedEvent #135

Closed thegecko closed 5 years ago

thegecko commented 5 years ago

Signed-off-by: thegecko rob.moran@arm.com

The StoppedEvent raised from the adapter supports a boolean allThreadsStopped flag to indicate to the UI that all threads have stopped. Gdb returns this in the stopped resultData as stopped-threads.

This PR marries the two up to fix scenarios such as the following:

Before:

Screenshot 2019-09-19 at 14 43 58

After:

Screenshot 2019-09-19 at 14 43 12
jonahgraham commented 5 years ago

run tests

jonahgraham commented 5 years ago

Thanks @thegecko - I had this on my list to check after raising questions about all vs non-stop so I am glad you fixed this. LGTM, just waiting for build machine to confirm.

However, if would be really nice to have a test for this. Do you have a multi-threaded test we can use here?

thegecko commented 5 years ago

However, if would be really nice to have a test for this. Do you have a multi-threaded test we can use here?

I don't unfortunately and time is very much against me