search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
28 stars 40 forks source link

Encode data in read memory request in base 64 #184

Closed colin-grant-work closed 3 years ago

colin-grant-work commented 3 years ago

This PR addresses the issue raised here regarding the mismatch between the DAP's ReadMemoryRespnose, which specifies a base64 string, and CDT-GDB's response, which is a hexidecimal string.

Signed-off-by: Colin Grant colin.grant@ericsson.com

colin-grant-work commented 3 years ago

@paul-marechal, would you mind taking a look at this when you get a chance?

eclipse-cdt-bot commented 3 years ago

Can one of the admins verify this patch?

colin-grant-work commented 3 years ago

@paul-marechal, I've modified the base conversion to throw errors if it detects incomplete bytes (odd number of hex digits) or ill-formed hex (Buffer is empty -> base64 string is empty).