search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
28 stars 40 forks source link

Fix Watch view for multiple session debugging. #224

Closed bangdang1411 closed 1 year ago

bangdang1411 commented 1 year ago

Description: In multiple session debugging, all sessions will send command to get result value of variables added in Watch view. But only 1 session can send command successfully, another session will catch the error and send ErrorResponse to client. The ErrorRespone makes another session fail and cannot update the remaining in Watch view.

Solution: Replace ErrorResponse by using response notify 'Error: could not evaluate expression'. It will show the error notify on another sessions that do not have the variable in source file.

bangdang1411 commented 1 year ago

Hi @jonahgraham-san, I pull a commit for fixing the bug relate to using watch view for multiple debugging (G4MH & ARM). This commit relates to https://github.com/eclipse-cdt-cloud/cdt-amalgamator/pull/3 It also fixes in the same ticket. Could you please help me take a look at my commit and give me your idea? Thank you.

bangdang1411 commented 1 year ago

Please provide a test.

This change seems to send two responses in case of error.

Hi, I find a new solution to set timeout in cdt-amalgamator. I think we do not need to change the response in cdt-gdb-adapter. So, I think this pull request should be suspended and we could review the solution in https://github.com/eclipse-cdt-cloud/cdt-amalgamator/pull/3 Thank you.