search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
28 stars 40 forks source link

Ensure terminated event is sent to client #234

Closed noneghost closed 1 year ago

noneghost commented 1 year ago

Consider that when no threads are running the inferior is not running. This is needed so we don't suppress sending events to client on async stopped events from gdb

Fixes #233

jonahgraham commented 1 year ago

Hi @Noneghost, thank you for the PR. Before we can consider the PR we need the ECA to be signed. See here for more details.

noneghost commented 1 year ago

Hi @Noneghost, thank you for the PR. Before we can consider the PR we need the ECA to be signed. See here for more details.

Hi @jonahgraham , I haved signed eca 3.1.0.

GitMensch commented 1 year ago

So, possibly take in, if we already know that there's an issue which is fixed by this? (I'm seeing the same issue - process is terminated but still "active" in the UI).

jonahgraham commented 1 year ago

So, possibly take in, [...]

Sorry, I don't know what you mean by this part?

GitMensch commented 1 year ago

If you know that the known bug is fixed I suggest to pull that as-is, and adding "more missing things" later.

jonahgraham commented 1 year ago

Thanks for expanding on what you meant. I am going to have a hard time accepting PRs without tests. But if @Noneghost is not able to code something up soon then I will look into this further.