search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
28 stars 40 forks source link

Stop gdbserver after debug session #258

Closed ArsenInstigate closed 1 year ago

ArsenInstigate commented 1 year ago

Added disconnectRequest function which stops gdbserver after debug session

jonahgraham commented 1 year ago

@ArsenInstigate can you please sign the Eclipse Contributor Agreement so we can accept your improvement. The first time contribution has a little bit of process hoops to jump through, but it should make future contributions quicker and easier.

ArsenInstigate commented 1 year ago

Hi @jonahgraham

I added the following futures, to my pull request

  1. Moved stop gdb server to separate function.
  2. Added timeout after killing gdbserver.
  3. Added test in integration-tests for stop gdb server.

On my board, it works. So what should be my next step?

jonahgraham commented 1 year ago

So what should be my next step?

Please sign the ECA

This change looks fine to me, I have pushed a couple of extra commits to fix formatting and make it possible to disable the new functionality as it seems to interfere with Renesas' use case in #256

jonahgraham commented 1 year ago

The PR run failed with this change on Windows. It looks like a probable flaky test so I have retriggered it.

jonahgraham commented 1 year ago

Thanks @ArsenInstigate!