Disconnect before exit for remote targets

[AdhamRagabMCHP]

This changes fixes an issue whereby when debugging on a remote target, the exit sequence is not entirely correct. We should send a "disconnect" GDB command before "exit". This prevents a messages such as "Remote doesn't know how to detach" and "Cannot execute this command while the target is running" from appearing, as they can be somewhat misleading.

To recreate this:

• Exit a remote debug session before this change.

To check that this works:

• Exit a remote debug session after this change. In place of the messages described above, you should see "disconnect" in the debug console if the logging level is at warn ("verbose" = false in the launch.json)/

[jonahgraham]

@AdhamRagabMCHP We'll give it a few days to give others a chance to comment. Feel free to ping me next week to merge it if there has been no further comment.

[AdhamRagabMCHP]

Sounds good!

[thegecko]

lgtm

[AdhamRagabMCHP]

@AdhamRagabMCHP We'll give it a few days to give others a chance to comment. Feel free to ping me next week to merge it if there has been no further comment.

Hello Jonah! I'm not sure if this PR is good to merge now - we can wait an additional day or so, but just curious if now's a good time to merge.

[sdirix]

I did not test the PR but from my understanding it should work fine for the Blueprint use cases. Therefore I'm fine with merging :+1:

[jonahgraham]

Thanks @thegecko and @sdirix for weighing in.

[jonahgraham]

Thanks @AdhamRagabMCHP for the fix. I can do a new version now, or wait until #271 is done. Let me know if you want it now.

[AdhamRagabMCHP]

Thanks @AdhamRagabMCHP for the fix. I can do a new version now, or wait until #271 is done. Let me know if you want it now.

I think we'll wait until #271 is done - it makes sense to have all the changes in first.