search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
30 stars 40 forks source link

Show socket connection errors in debugger #286

Closed AdhamRagabMCHP closed 1 year ago

AdhamRagabMCHP commented 1 year ago

This PR complements PR #281 and does the equivalent for the socket port connection.

A similar test has also been added to test the error message.

AdhamRagabMCHP commented 1 year ago

Hello @jonahgraham! Thanks so much for your review! I would love a new version with this change, yes - I'm assuming the VSX Registry will be rebuilt overnight?

jonahgraham commented 1 year ago

I would love a new version with this change, yes

OK - I'll do the version bumps and push that soon - but I am running out of time today to do it.

I'm assuming the VSX Registry will be rebuilt overnight?

Yes, once I push everything it should be available overnight that night - I expect I'll get to it tomorrow.

AdhamRagabMCHP commented 1 year ago

I would love a new version with this change, yes

OK - I'll do the version bumps and push that soon - but I am running out of time today to do it.

I'm assuming the VSX Registry will be rebuilt overnight?

Yes, once I push everything it should be available overnight that night - I expect I'll get to it tomorrow.

No worries! Thanks so much!

jonahgraham commented 1 year ago

Newest version published https://www.npmjs.com/package/cdt-gdb-adapter?activeTab=versions and cdt-gdb-vscode udpated to reference it https://github.com/eclipse-cdt-cloud/cdt-gdb-vscode/commit/1d3e69d40043c2db34dee97639d1e71cde2c46be

Version 0.0.101 of cdt-gdb-vscode should publish overnight to open vsx.

AdhamRagabMCHP commented 1 year ago

Newest version published https://www.npmjs.com/package/cdt-gdb-adapter?activeTab=versions and cdt-gdb-vscode udpated to reference it eclipse-cdt-cloud/cdt-gdb-vscode@1d3e69d

Version 0.0.101 of cdt-gdb-vscode should publish overnight to open vsx.

Hey @jonahgraham! I was just checking the Open VSX Registry and I'm not sure 0.0.101 is published yet: https://open-vsx.org/extension/eclipse-cdt/cdt-gdb-vscode I'm wondering if you're seeing this on your end as well!

jonahgraham commented 1 year ago

I see the same - Not sure what is happening, please follow new issue https://github.com/eclipse-cdt-cloud/cdt-gdb-vscode/issues/95 for updates.

AdhamRagabMCHP commented 1 year ago

I see the same - Not sure what is happening, please follow new issue eclipse-cdt-cloud/cdt-gdb-vscode#95 for updates.

Sounds good, thanks so much!