search

eclipse-cdt-cloud / cdt-gdb-adapter

CDT GDB Debug Adapter
Eclipse Public License 2.0
27 stars 40 forks source link

Add additional info to MIBreakpointInfo #290

Closed colin-grant-work closed 9 months ago

colin-grant-work commented 10 months ago

There is a note on the MIBreakpointInfo interface that there are a number of fields not included in its current definition. This MR adds a few based on a reading of the print_one_breakpoint_location function.

jonahgraham commented 10 months ago

PS You can merge at your convenience.

colin-grant-work commented 10 months ago

https://sourceware.org/gdb/current/onlinedocs/gdb.html/GDB_002fMI-Breakpoint-Information.html is the documentation for this structure.

Thanks for the pointer! I was working with this, but it seemed to barely scratch the surface, which is why I resorted to the source. Shall I add all the documented fields, as well?

FWIW frame and script while being in the breakpoint.c code don't exist in the documentation.

script is one I do want to get in; frame I can take or leave, if you'd rather not include it.

jonahgraham commented 10 months ago

It would be great to have all of them in there, but I don't want to hold up what you are trying to achieve.

colin-grant-work commented 9 months ago

@jonahgraham, from comments elsewhere, it looks like the Windows test failures (to run at all) are due to a GitHub change. If that's the case, shall I merge this?

jonahgraham commented 9 months ago

Yes - please merge. I will resolve the underlying issue soon in #299