search

eclipse-cdt-cloud / theia-trace-extension

Eclipse Theia trace viewer extension using the Trace Server Protocol (TSP), through the tsp-typescript-client. Also the home for reusable JavaScript libraries: traceviewer-base, traceviewer-react-components
MIT License
48 stars 60 forks source link

Trace Server Server error messages should be handled gracefully #234

Open MatthewKhouzam opened 3 years ago

MatthewKhouzam commented 3 years ago

If a server crashes (e.g. vm goes down) the front end should handle it gracefully and inform the user of the issue.

MatthewKhouzam commented 3 years ago

Assigned people to be aware of the issue, since they are working on the same problem from different aspects.

paul-marechal commented 3 years ago

I was about to open a similar issue: I tried running the trace server from the status bar nothing happened but had the following trace in the logs:

root ERROR Uncaught Exception:  Error: spawn ../trace-compass-server/tracecompass-server ENOENT
root ERROR Error: spawn ../trace-compass-server/tracecompass-server ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
root ERROR [hosted-plugin: 4299] Promise rejection not handled in one second: undefined , reason: undefined

In this case I forgot to pull the trace server jar, but showing something in the UI could help?

mirsky-work commented 3 years ago

@marechal-p, #226 adds a toast message in that scenario.

ebugden commented 3 years ago

I'm un-assigning myself because I won't be working on this in the immediate future. @MatthewKhouzam Thanks for mentioning this important issue!