eclipse-cdt-cloud / theia-trace-extension

Eclipse Theia trace viewer extension using the Trace Server Protocol (TSP), through the tsp-typescript-client. Also the home for reusable JavaScript libraries: traceviewer-base, traceviewer-react-components
MIT License
49 stars 60 forks source link

Discuss and choose the good zoom factor for the client #425

Open IbrahimFradj opened 3 years ago

IbrahimFradj commented 3 years ago

We need to discuss the zoom factor in the xy charts and time graph charts and make a decision on which factor to choose. After testing zooming out in the time graph charts, I noticed that at some point the zoom factor would change abruptly and I would get lost. In the time graph charts, we use "const zoomMagnitude = hasZoomedIn ? 0.8 : 1.25 ;" but in the xy charts, we use a 10% change every time we zoom in or out.

Here is the result with the time graph charts

Zooming factor

You can notice that at the beginning when I zoom in or out the zoom factor was constant but just when I get to the extreme right and zoom out again the factor changes completely and it zooms out much more than it did at first Here is the images image

image

ER = extreme right

Here is the result with XY charts

Zooming factor 2

We can notice with the xy charts that the zoom in and zoom out are constant depending on the mouse position

ebugden commented 3 years ago

What was the reason for having the zoom factor become larger when the beginning or the end of the trace is in view?


I'd like to hear @ssmagula's thoughts as well!

My quick thoughts (caveat: as a designer not a user) are that predictability and consistent feel should be the priority for navigation: