search

eclipse-cdt-cloud / theia-trace-extension

Eclipse Theia trace viewer extension using the Trace Server Protocol (TSP), through the tsp-typescript-client. Also the home for reusable JavaScript libraries: traceviewer-base, traceviewer-react-components
MIT License
48 stars 60 forks source link

Resources Status filler row height too big #802

Open bhufmann opened 1 year ago

bhufmann commented 1 year ago

The Resources Status view of the Trace Compass server has a filler row between the CPUs to visually separate the CPUs. However, the filler row is drawn with the same height as a regular row which wastes vertical space and doesn't have a great UX.

To support this independently from the trace server and view, such filler rows need to be styled through the data provider TSP API.

Theia Trace Extension with Trace Compass server: image

In Eclipse Trace Compass it looks like this: image

williamsyang-work commented 1 year ago

There is no explicit identifier for the "filler rows", but they all come in with an empty string "" as their name. Filler rows can be identified height set through the Row Style Provider easily. But we can move forward by identifying filler rows either by:

  1. Identify "filler rows" by their empty string name "".

    • Simple fix, can be contained to this repository.

  2. Add an explicit tag for "filter rows" on the back end.

    • More complicated, but cleaner and less 'hacky'.
bhufmann commented 1 year ago

what about using height style in the model?

https://github.com/eclipse-cdt-cloud/trace-server-protocol/blob/569aac4cc29f899012b226b37c7b349bba6f78f3/API.yaml#L1721