Closed marco-miller closed 3 years ago
I put the comments from the wrong account, but they are still correct.
I am not convinced by this approach, I would argue we could just update the current instead of having two APIs... if someone comes out of nowhere and sees two APIs... I suspect their reaction would be odd.
Also, we need to determine which one we want. Honestly, the one we have from trace compass is functional, but not clean, the one we have here is clean but not 100% functional. I assume there should be an in between. My 2c though.
Thanks @MatthewKhouzam for the review. @bhufmann, should we change our originally wanted approach based on the 2 APIs? I'm fine either way, but we need to decide on if we keep both or not, at least for the time being. I agree with @TheMatthew that publishing 2 APIs at once for a while might momentarily be confusing. But again, these changes are step-wise and incremental anyway.
Thanks @MatthewKhouzam for the review. @bhufmann, should we change our originally wanted approach based on the 2 APIs? I'm fine either way, but we need to decide on if we keep both or not, at least for the time being. I agree with @TheMatthew that publishing 2 APIs at once for a while might momentarily be confusing. But again, these changes are step-wise and incremental anyway.
Any news here?
Thanks @MatthewKhouzam for the review. @bhufmann, should we change our originally wanted approach based on the 2 APIs? I'm fine either way, but we need to decide on if we keep both or not, at least for the time being. I agree with @TheMatthew that publishing 2 APIs at once for a while might momentarily be confusing. But again, these changes are step-wise and incremental anyway.
Any news here?
Yeah a bit tricky. Maybe the one from Trace Compass swagger should be in a sub-directory for now, so tit's less confusing? And the index.html we don't publish then until it's more progressed?
Yeah a bit tricky. Maybe the one from Trace Compass swagger should be in a sub-directory for now, so tit's less confusing? And the index.html we don't publish then until it's more progressed?
That was the goal of #63 as this PR's very companion.
Add the yaml file currently generated by the Swagger endpoint recently added to trace-server.
Add a corresponding README section that explains the full context, while listing steps to undertake and current ways of generating openapi.yaml.
This change assumes a companion commit (#63) in the gh-pages branch, that adds a ./swagger/index.html file linking to this new openapi.yaml file. That added index file is likely a copy of ./index.html in gh-pages, only not pointing to API.yaml as such.
Fixes #61 partially as first steps.
Signed-off-by: Marco Miller marco.miller@ericsson.com