eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector
https://open-vsx.org/extension/eclipse-cdt/memory-inspector
Eclipse Public License 2.0
6 stars 10 forks source link

Sort all imports #101

Closed colin-grant-work closed 7 months ago

colin-grant-work commented 7 months ago

What it does

Fixes https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/issues/98

I don't have strong feelings about import ordering, but I do have strong feelings about extraneous lines in a diff, and some people have local setups that automatically sort imports in different ways. This PR introduces lint rules that should enforce deterministic ordering of imports and applies them across the code base so that in the future, we should have a common standard for import ordering and we shouldn't run into cases where a PR spontaneously introduces a new order.

Others may have strong feelings: they may want a different order, or not want these lint rules at all. Please speak up if so.

How to test

  1. This shouldn't do anything but reorder a bunch of imports, so if CI passes, it's probably fine.

Review checklist

Reminder for reviewers